fix(config) :: document the real configuration defaults' - #1391
Open
81reap wants to merge 1 commit into
Open
Conversation
lovasoa
requested changes
Aug 18, 2026
| | --------------------------------------------- | ----------------------------------------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ | | ||
| | `listen_on` | 0.0.0.0:8080 | Interface and port on which the web server should listen | | ||
| | `database_url` | `sqlite://sqlpage.db?mode=rwc` or `DSN=DuckDB` | Database connection URL, either `dbengine://user:password@host:port/dbname` or an ODBC connection string. Special characters should be [percent-encoded](https://developer.mozilla.org/en-US/docs/Glossary/percent-encoding). See [Database connection strings](#database-connection-strings) for details and examples.| | ||
| | `listen_on` | 0.0.0.0:8080, or 0.0.0.0:443 when `https_domain` is set | Interface and port on which the web server should listen | |
Collaborator
There was a problem hiding this comment.
I do not think this is true. When https_domain is set, but a port number different from 443 is set, SQLPage starts both an HTTP and an HTTPS server. This makes me suspicious about the entire PR. Is this entirely LLM generated, or are these issues you actually encountered while configuring your SQLPage instance ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses B1 in #1386