Skip to content

Fix wrong link targets in react-dom docs - #8599

Open
see-stack wants to merge 1 commit into
reactjs:mainfrom
see-stack:fix-more-wrong-links
Open

Fix wrong link targets in react-dom docs#8599
see-stack wants to merge 1 commit into
reactjs:mainfrom
see-stack:fix-more-wrong-links

Conversation

@see-stack

Copy link
Copy Markdown
Contributor

Three links pointed to the wrong page:

  • resume linked to renderToReadableStream (should be resume)
  • react-dom/server linked to createRoot (should be server)
  • renderToPipeableStream linked to renderToReadableStream (should be renderToPipeableStream)

@github-actions

Copy link
Copy Markdown

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@deepusnath deepusnath left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified. hydrateRoot.md:126 says "generated by react-dom/server" while linking to client/createRoot, so the link text and destination disagree. /reference/react-dom/server exists as a target. Correct fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants