remove isOrdered from the function grammar - #29
Merged
Conversation
Drop `isOrdered` from `aggregateFunctions` so it no longer surfaces in autocomplete. The CREATE TABLE column-type test used `isOrdered` as its sentinel for "no functions suggested here"; with the entry gone that assertion would pass vacuously, so it now uses `is_leap_year` — still an `i`-prefixed function in the grammar, so the test keeps proving what it was written to prove. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Removes the two `isOrdered` queries from docs-queries.json, so no trace of the function remains in the repo. Fixture goes 1799 -> 1797 entries; no test asserts a fixed count. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
javier
approved these changes
Aug 18, 2026
This was referenced Aug 18, 2026
Merged
emrberk
added a commit
to questdb/ui
that referenced
this pull request
Aug 19, 2026
bump @questdb/sql-parser to 0.1.17, e2e submodule to latest master sql-parser 0.1.17 drops isOrdered from the grammar (questdb/sql-parser#29); nothing in src/ references it. Also advances the e2e/questdb submodule 16 commits to fbbe40f4. Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
isOrderedfrom the grammar. No reference to the function remains anywhere in the repo.Changes
src/grammar/functions.ts— droppedisOrderedfromaggregateFunctions, so it no longer surfaces in autocomplete.tests/fixtures/docs-queries.json— removed the two docs-sourced queries that calledisOrdered(1799 to 1797 entries; no test asserts a fixed count).tests/autocomplete.test.ts— theCREATE TABLE x (id itest usedisOrderedas its sentinel for "no functions suggested in a column-type position". With the entry gone from the grammar that assertion would pass vacuously, so it now usesis_leap_year— still ani-prefixed function in the grammar, keeping the test meaningful.Verification
yarn test— 6986 passed (9 files). Down 6 from the 6992 on master: the two removed fixture queries across the parse, round-trip, and autocomplete docs suites.yarn typecheck— cleanyarn lint— clean🤖 Generated with Claude Code