Skip to content

fix(sankey): transpose node.x/node.y scaling for vertical orientation #7957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
waterWang wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −4
Open

fix(sankey): transpose node.x/node.y scaling for vertical orientation #7957

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions src/traces/sankey/render.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,9 @@ function sankeyModel(layout, d, traceIndex) {
if(trace.node.x.length && trace.node.y.length) {
for(i = 0; i < Math.min(trace.node.x.length, trace.node.y.length, graph.nodes.length); i++) {
if(trace.node.x[i] && trace.node.y[i]) {
var pos = [trace.node.x[i] * width, trace.node.y[i] * height];
var pos = horizontal
? [trace.node.x[i] * width, trace.node.y[i] * height]
: [trace.node.x[i] * height, trace.node.y[i] * width];
graph.nodes[i].x0 = pos[0] - nodeThickness / 2;
graph.nodes[i].x1 = pos[0] + nodeThickness / 2;

Expand Down Expand Up @@ -802,9 +804,13 @@ function persistFinalNodePositions(d, gd) {
for(var i = 0; i < d.graph.nodes.length; i++) {
var nodeX = (d.graph.nodes[i].x0 + d.graph.nodes[i].x1) / 2;
var nodeY = (d.graph.nodes[i].y0 + d.graph.nodes[i].y1) / 2;
x.push(nodeX / d.figure.width);
y.push(nodeY / d.figure.height);
}
if(d.trace.orientation === 'h') {

@camdecoster camdecoster Aug 18, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This value is already saved on d:

Suggested change
if(d.trace.orientation === 'h') {
if(d.horizontal) {

x.push(nodeX / d.figure.width);
y.push(nodeY / d.figure.height);
} else {
x.push(nodeX / d.figure.height);
y.push(nodeY / d.figure.width);
}

@camdecoster camdecoster Aug 18, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you missed a paren.

Suggested change
}
}
}

Registry.call('_guiRestyle', gd, {
'node.x': [x],
'node.y': [y]
Expand Down
Loading