Fixes CI failure introduced by #23345 - #23382
Merged
Merged
Conversation
Member
|
Also cc @lacatoire |
Girgias
approved these changes
Aug 19, 2026
devnexen
requested changes
Aug 19, 2026
| @@ -0,0 +1,26 @@ | |||
| --TEST-- | |||
Member
There was a problem hiding this comment.
--- a/ext/sockets/tests/socket_cmsg_space_overflow_64bit.phpt
+++ b/ext/sockets/tests/socket_cmsg_space_num_range_64bit.phpt
@@ -7,19 +7,14 @@
if (PHP_INT_SIZE < 8) {
die('skip 64-bit only');
}
-if (PHP_OS_FAMILY === 'Windows') {
- die('skip SCM_RIGHTS not available on Windows');
-}
-if (!defined('SCM_RIGHTS')) {
- die('skip SCM_RIGHTS not defined on this platform');
-}
?>
--FILE--
<?php
+// $num is range checked before the level/type pair is looked up
try {
- socket_cmsg_space(SOL_SOCKET, SCM_RIGHTS, PHP_INT_MAX);
+ socket_cmsg_space(SOL_SOCKET, 0, PHP_INT_MAX);
} catch (Throwable $e) {
- echo $e::class, ': ', $e->getMessage(), "\n";
+ echo $e::class, ': ', $e->getMessage(), PHP_EOL;
}
?>
--EXPECT--
Member
There was a problem hiding this comment.
maybe do not pay attention to the last line change though now I realise ..
Contributor
Author
There was a problem hiding this comment.
Done. Amended; forgot to add co-authored, feel free on merge.
NickSdot
force-pushed
the
fix/assertion-23345
branch
from
August 19, 2026 15:31
8c9d7ad to
d46665d
Compare
devnexen
approved these changes
Aug 19, 2026
Member
|
Thanks ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes CI failures caused by #23345:
Ref: https://github.com/php/php-src/actions/runs/32253251276/job/96068998524?pr=23378