ext/gd: Fix incorrect argument numbers in GD affine function errors - #23356
Merged
Conversation
LamentXU123
marked this pull request as draft
August 18, 2026 18:38
LamentXU123
marked this pull request as ready for review
August 18, 2026 18:39
Girgias
approved these changes
Aug 18, 2026
Member
|
It would probably make sense for master to create a custom ZPP specifier for |
devnexen
approved these changes
Aug 18, 2026
NickSdot
reviewed
Aug 18, 2026
Co-authored-by: NickSdot <32384907+NickSdot@users.noreply.github.com>
Member
Author
This makes sense in the long-term. Perhaps another good first issue here. |
LamentXU123
added a commit
that referenced
this pull request
Aug 19, 2026
* PHP-8.5: ext/gd: Fix incorrect argument numbers in GD affine function errors (#23356)
pull Bot
pushed a commit
to ppker/php-src
that referenced
this pull request
Aug 19, 2026
* PHP-8.4: ext/gd: Fix incorrect argument numbers in GD affine function errors (php#23356)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes wrong argument in error message in imageaffinematrixget and mageaffinematrixconcat