Skip to content

Fix CodespaceLocation locations and machine CPU cores metric - #3087

Open
noraa-junker wants to merge 1 commit into
octokit:mainfrom
noraa-junker:fixCodespacesApi
Open

Fix CodespaceLocation locations and machine CPU cores metric#3087
noraa-junker wants to merge 1 commit into
octokit:mainfrom
noraa-junker:fixCodespacesApi

Conversation

@noraa-junker

Copy link
Copy Markdown
Contributor

Resolves #3086


Before the change?

Machine.CpuCount does no longer propagate the correct value as the field was renamed to Cpus.

The CodespaceLocation enum is outdated.

After the change?

  • Adds a new Machine.Cpus field and Machine.CpuCount stays as an alias.
  • All the old CodespaceLocation values have been removed and were replaced with the current ones.

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🆕 Triage

Development

Successfully merging this pull request may close these issues.

[BUG]: Codespaces API has fields that are outdated

2 participants