fix: forward onBodySent/onRequestSent through interceptor handlers - #5696
Open
adarshx01 wants to merge 1 commit into
Open
fix: forward onBodySent/onRequestSent through interceptor handlers#5696adarshx01 wants to merge 1 commit into
adarshx01 wants to merge 1 commit into
Conversation
DecoratorHandler swallowed onBodySent with a no-op, and RetryHandler, RedirectHandler, and CacheHandler never implemented the hooks, so composing an interceptor silently dropped them. Co-authored-by: Cursor <cursoragent@cursor.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5696 +/- ##
=======================================
Coverage 93.47% 93.47%
=======================================
Files 110 110
Lines 38846 38876 +30
=======================================
+ Hits 36310 36341 +31
+ Misses 2536 2535 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5695.
Requestonly callsonBodySent/onRequestSentwhen those methods exist on the handler.DecoratorHandlerdefinedonBodySentas a no-op, so the chunk was swallowed, andonRequestSentwas missing entirely.RetryHandler,RedirectHandler, andCacheHandlerwrap the user handler themselves and never forwarded either hook.Composing
interceptors.retry(),redirect(),cache(), or anything that extendsDecoratorHandlertherefore silently dropped both callbacks. They now pass through the same wayonRequestStartalready does.Test plan
node --test test/decorator-handler.js test/interceptors/body-sent-hooks.jsClientstill fires both hooksDecoratorHandler,interceptors.retry(),interceptors.cache(), andinterceptors.redirect()Made with Cursor