Skip to content

sqlite: remove unused column name helper - #65401

Open
trivikr wants to merge 1 commit into
nodejs:mainfrom
trivikr:sqlite-unused-statement-executionhelper
Open

sqlite: remove unused column name helper#65401
trivikr wants to merge 1 commit into
nodejs:mainfrom
trivikr:sqlite-unused-statement-executionhelper

Conversation

@trivikr

@trivikr trivikr commented Aug 19, 2026

Copy link
Copy Markdown
Member

Refs: #65276

Remove the unused column name helper from StatementExecutionHelper.
It became unused after all() and get() switched to cached names.

Remove the unused column name helper from StatementExecutionHelper.
It became unused after all() and get() switched to cached names.

Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/sqlite

@trivikr
trivikr requested a review from geeksilva97 August 19, 2026 14:14
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem. labels Aug 19, 2026
@trivikr trivikr added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 19, 2026
@codecov

codecov Bot commented Aug 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.09%. Comparing base (9c641c5) to head (0cfdb00).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #65401      +/-   ##
==========================================
- Coverage   90.11%   90.09%   -0.02%     
==========================================
  Files         752      752              
  Lines      252200   252191       -9     
  Branches    47433    47438       +5     
==========================================
- Hits       227267   227222      -45     
- Misses      16239    16277      +38     
+ Partials     8694     8692       -2     
Files with missing lines Coverage Δ
src/node_sqlite.cc 82.05% <ø> (+0.24%) ⬆️
src/node_sqlite.h 86.00% <ø> (ø)

... and 26 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. request-ci Add this label to start a Jenkins CI on a PR. sqlite Issues and PRs related to the SQLite subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants