src: remove --harmony-import-attributes - #65396
Open
o- wants to merge 1 commit into
Open
Conversation
Import attributes have been enabled by default since V8 M123 and are now standard in JavaScript. Remove the hardcoded injection of the flag in Node.js so that the flag can be deprecated and removed upstream in V8. Refs: https://chromium-review.googlesource.com/c/v8/v8/+/8260695 Signed-off-by: Olivier Flückiger <olivf@chromium.org>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
Contributor
Author
|
@aduh95 friendly ping |
aduh95
approved these changes
Aug 19, 2026
aduh95
added
author ready
github-actions
Bot
removed
the
request-ci
Collaborator
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65396 +/- ##
==========================================
- Coverage 90.13% 90.12% -0.02%
==========================================
Files 752 752
Lines 251864 251860 -4
Branches 47354 47365 +11
==========================================
- Hits 227021 226982 -39
- Misses 16180 16223 +43
+ Partials 8663 8655 -8
🚀 New features to boost your workflow:
|
Collaborator
legendecas
approved these changes
Aug 19, 2026
richardlau
approved these changes
Aug 19, 2026
richardlau
added
the
commit-queue
lpinca
approved these changes
Aug 19, 2026
juanarbol
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Import attributes have been enabled by default since V8 M123 and are now standard in JavaScript. Remove the hardcoded injection of the flag in Node.js so that the flag can be deprecated and removed upstream in V8.
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/8260695
Refs: #61898