sqlite: reuse cached column names in all() and get() - #65276
Merged
nodejs-github-bot merged 1 commit intoAug 18, 2026
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
geeksilva97
force-pushed
the
post/column-name-cache
branch
from
August 14, 2026 03:48
c7fbb27 to
2822d7d
Compare
araujogui
reviewed
Aug 14, 2026
Signed-off-by: geeksilva97 <edigleyssonsilva@gmail.com>
geeksilva97
force-pushed
the
post/column-name-cache
branch
from
August 14, 2026 13:37
2822d7d to
c83e627
Compare
geeksilva97
marked this pull request as ready for review
August 14, 2026 13:49
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #65276 +/- ##
=======================================
Coverage 90.32% 90.32%
=======================================
Files 751 751
Lines 250000 249977 -23
Branches 47231 47226 -5
=======================================
- Hits 225816 225803 -13
- Misses 15566 15571 +5
+ Partials 8618 8603 -15
🚀 New features to boost your workflow:
|
cjihrig
approved these changes
Aug 15, 2026
github-actions
Bot
removed
the
request-ci
Collaborator
geeksilva97
added
the
author ready
Collaborator
Collaborator
trivikr
approved these changes
Aug 17, 2026
Collaborator
trivikr
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/65276 ✔ Done loading data for nodejs/node/pull/65276 ----------------------------------- PR info ------------------------------------ Title sqlite: reuse cached column names in all() and get() (#65276) Author Edy Silva <edigleyssonsilva@gmail.com> (@geeksilva97) Branch geeksilva97:post/column-name-cache -> nodejs:main Labels c++, author ready, needs-ci, commit-queue, sqlite Commits 1 - sqlite: reuse cached column names in statement all() and get() Committers 1 - geeksilva97 <edigleyssonsilva@gmail.com> PR-URL: https://github.com/nodejs/node/pull/65276 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/65276 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 14 Aug 2026 03:45:09 GMT ✔ Approvals: 3 ✔ - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/65276#pullrequestreview-4944096915 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/65276#pullrequestreview-4944479607 ✔ - Trivikram Kamat (@trivikr): https://github.com/nodejs/node/pull/65276#pullrequestreview-4947917214 ✘ GitHub CI is still running ℹ Last Full PR CI on 2026-08-17T05:01:25Z: https://ci.nodejs.org/job/node-test-pull-request/75907/ - Querying data for job/node-test-pull-request/75907/ ✔ Build data downloaded ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/32002702127 |
geeksilva97
added
commit-queue
nodejs-github-bot
added
commit-queue-failed
Collaborator
Commit Queue failed- Loading data for nodejs/node/pull/65276 ✔ Done loading data for nodejs/node/pull/65276 ----------------------------------- PR info ------------------------------------ Title sqlite: reuse cached column names in all() and get() (#65276) Author Edy Silva <edigleyssonsilva@gmail.com> (@geeksilva97) Branch geeksilva97:post/column-name-cache -> nodejs:main Labels c++, author ready, needs-ci, commit-queue, sqlite Commits 1 - sqlite: reuse cached column names in statement all() and get() Committers 1 - geeksilva97 <edigleyssonsilva@gmail.com> PR-URL: https://github.com/nodejs/node/pull/65276 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/65276 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 14 Aug 2026 03:45:09 GMT ✔ Approvals: 3 ✔ - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/65276#pullrequestreview-4944096915 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/65276#pullrequestreview-4944479607 ✔ - Trivikram Kamat (@trivikr): https://github.com/nodejs/node/pull/65276#pullrequestreview-4947917214 ✘ GitHub CI is still running ℹ Last Full PR CI on 2026-08-17T06:43:11Z: https://ci.nodejs.org/job/node-test-pull-request/75907/ - Querying data for job/node-test-pull-request/75907/ ✔ Build data downloaded ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/32022868997 |
This comment was marked as outdated.
This comment was marked as outdated.
github-actions
Bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
trivikr
added
commit-queue
Collaborator
|
Landed in cf30b2e |
nodejs-github-bot
removed
the
commit-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes StatementSync.prototype.all and StatementSync.prototype.get to leverage existing cache