-
-
Notifications
You must be signed in to change notification settings - Fork 145
feat: post CI results in PRs #684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
avivkeller
wants to merge
1
commit into
nodejs:main
Choose a base branch
from
avivkeller:jenkins-pr-status
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| import { Writable } from 'node:stream' | ||
|
|
||
| import CLI from 'node-core-utils/lib/cli.js' | ||
| import Request from 'node-core-utils/lib/request.js' | ||
| import { PRBuild } from 'node-core-utils/lib/ci/build-types/pr_build.js' | ||
|
|
||
| import { createPrComment } from './github-comment.js' | ||
|
|
||
| export function extractBuildNumber (build) { | ||
| // e.g. https://ci.nodejs.org/job/node-test-pull-request/21633/ | ||
| const match = /\/job\/node-test-pull-request\/(\d+)/.exec(build.url || '') | ||
| return match ? parseInt(match[1], 10) : null | ||
| } | ||
|
|
||
| export async function fetchResultsMarkdown (buildNumber) { | ||
| // node-core-utils insists on writing progress output to a stream | ||
| const nullStream = new Writable({ write (chunk, encoding, callback) { callback() } }) | ||
| const cli = new CLI(nullStream) | ||
| const request = new Request({ | ||
| jenkins: Buffer.from(process.env.JENKINS_API_CREDENTIALS).toString('base64') | ||
| }) | ||
|
|
||
| const prBuild = new PRBuild(cli, request, buildNumber) | ||
| await prBuild.getResults() | ||
| return prBuild.formatAsMarkdown() | ||
| } | ||
|
|
||
| export async function postBuildResults (options, build, fetchResults = fetchResultsMarkdown) { | ||
| const { pr } = options | ||
| const buildNumber = extractBuildNumber(build) | ||
|
|
||
| const traceFields = { pr, job: build.identifier, gitRef: build.ref, buildNumber } | ||
| const logger = options.logger.child(traceFields, true) | ||
|
|
||
| if (!process.env.JENKINS_API_CREDENTIALS) { | ||
| logger.info('JENKINS_API_CREDENTIALS is not set, skipping CI results comment') | ||
| return | ||
| } | ||
|
|
||
| if (buildNumber === null) { | ||
| logger.warn('Unable to find build number in build URL, skipping CI results comment') | ||
| return | ||
| } | ||
|
|
||
| const markdown = await fetchResults(buildNumber) | ||
|
|
||
| if (!markdown) { | ||
| logger.warn('Got no CI results back from node-core-utils, skipping CI results comment') | ||
| return | ||
| } | ||
|
|
||
| await createPrComment({ issue_number: pr, ...options, logger }, markdown) | ||
| logger.info('Jenkins CI results comment posted') | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this markdown be longer than GitHub’s max issue comment length?
https://github.com/dead-claudia/github-limits#issue-comments