[bug-fix] Fix qodercli-skills-migration: migrate QodercliIntegration to SkillsIntegration - #4205
Draft
github-actions[bot] wants to merge 1 commit into
Draft
Conversation
…ntegration Apply the remediation from the bug assessment on issue #4199. Qoder IDE 1.24+ dropped .qoder/commands/ scanning in favour of the skills layout (.qoder/skills/{skill-name}/SKILL.md). Migrated QodercliIntegration from MarkdownIntegration to SkillsIntegration, updating config[commands_subdir] to 'skills' and registrar_config[dir] to '.qoder/skills' with extension '/SKILL.md'. Updated tests to use SkillsIntegrationTests base mixin. Refs #4199 Assisted-by: GitHub Copilot (model: claude-sonnet-4.6, autonomous) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug fix — qodercli-skills-migration
Proposed fix for issue #4199, applying the remediation from the bug assessment.
Verdict: Valid · Severity: high
Summary
Migrated
QodercliIntegrationfromMarkdownIntegrationtoSkillsIntegration, changing the output layout from flat.qoder/commands/speckit.*.mdfiles to the.qoder/skills/speckit-<name>/SKILL.mddirectory-per-skill structure that Qoder IDE 1.24+ requires for slash-command discovery.Changes
src/specify_cli/integrations/qodercli/__init__.pyMarkdownIntegration→SkillsIntegration; updatedcommands_subdirto"skills",registrar_config["dir"]to".qoder/skills", andextensionto"/SKILL.md"tests/integrations/test_integration_qodercli.pyMarkdownIntegrationTestsforSkillsIntegrationTests; updatedCOMMANDS_SUBDIRto"skills"andREGISTRAR_DIRto".qoder/skills"Tests Added or Updated
TestQodercliIntegration(inheritingSkillsIntegrationTests) — pins that the integration is aSkillsIntegrationsubclass, that files land under.qoder/skills/speckit-<name>/SKILL.md, and that eachSKILL.mdcontains aname: speckit-<name>frontmatter field. All assertions are inherited from the sharedSkillsIntegrationTestsmixin.Local Verification
CodexIntegrationpattern exactly, which is already covered by the sharedSkillsIntegrationTestssuite.Deviations from Assessment
None. The preferred remediation was applied as specified. The
SkillsIntegrationbase class handlesnamefrontmatter injection automatically — no customsetup()override was needed.Risks & Review Notes
.qoder/commands/files from older installs will need to re-runspecify integration install qoderclito pick up the new layout. Old files will not be automatically removed unless still tracked in the manifest. Aspecify integration reinstall qoderclihint in release notes is recommended.Refs #4199 · cc
@mengqiang81