fix: enforce size limit on individual files in build_bundle() - #3911
Open
Quratulain-bilal wants to merge 3 commits into
Open
fix: enforce size limit on individual files in build_bundle()#3911Quratulain-bilal wants to merge 3 commits into
Quratulain-bilal wants to merge 3 commits into
Conversation
mnriem
requested changes
Aug 10, 2026
mnriem
left a comment
mnriem
left a comment
Collaborator
There was a problem hiding this comment.
Please resolve conflicts
build_bundle() called read_bytes() without any size guard. A single large asset file could exhaust memory. Enforce MAX_ZIP_MEMBER_BYTES (10 MiB) limit before reading.
Enforce MAX_ZIP_MEMBER_BYTES (10 MiB) limit before reading each file via os.fstat() on the same file descriptor used for reading, avoiding a TOCTOU gap between stat() and read_bytes(). Add regression tests: oversized file (>limit) is rejected, file at exact limit is accepted. Co-authored-by: GitHub Copilot (model: mimo-v2.5-free, supervised)
Quratulain-bilal
force-pushed
the
fix/bundle-unbounded-read
branch
from
August 10, 2026 21:38
0724b00 to
9f59bfb
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds per-file size enforcement when building bundle archives.
Changes:
- Rejects files exceeding the 10 MiB member limit.
- Adds oversized and boundary-size tests.
Show a summary per file
| File | Description |
|---|---|
src/specify_cli/bundler/services/packager.py |
Adds file-size validation before archive writes. |
tests/unit/test_bundler_packager.py |
Tests rejection and exact-limit acceptance. |
Review details
馃挕 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Balanced
Comment on lines
101
to
105
| if st.st_size > MAX_ZIP_MEMBER_BYTES: | ||
| raise BundlerError( | ||
| f"Bundle file {arcname} exceeds {MAX_ZIP_MEMBER_BYTES}-byte limit" | ||
| ) | ||
| archive.writestr(info, fh.read()) |
fstat() is only a snapshot; another process can append to the file after the check. Read MAX_ZIP_MEMBER_BYTES + 1 bytes and validate the length so the limit cannot be bypassed by a concurrent writer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
build_bundle()calledread_bytes()without any size guard. A single large asset file could exhaust memory.Fix
Enforce
MAX_ZIP_MEMBER_BYTES(10 MiB) limit before reading each file.Testing