cxx/python/rust: propagate UnixEnvInfo - #1459
Open
lf- wants to merge 1 commit into
Open
Conversation
Motivation: I want to pass shared library dependencies through my binary targets, so that `snowydeer_package` (our nix package builder; see my LixCon 2026 talk and https://github.com/mercurytechnologies/snowydeer) can automatically include them in the `lib/` directory in the output. Implementation/test plan: honestly this is a *massive* YOLO. This is clauded and I am *absolutely* not sure why this propagation was originally disabled, nor do I have enough tests out of tree to meaningfully exercise it. This is more of a question for why it was off in the first place with a "yolo" button than a normal PR :)
meta-cla
Bot
added
the
CLA Signed
Contributor
|
This pull request has been imported. If you are a Meta employee, you can view this in D115807594. (Because this pull request was imported automatically, there will not be any future comments.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation: I want to pass shared library dependencies through my binary targets, so that
snowydeer_package(our nix package builder; see my LixCon 2026 talk and https://github.com/mercurytechnologies/snowydeer) can automatically include them in thelib/directory in the output.Implementation/test plan: honestly this is a massive YOLO. This is clauded and I am absolutely not sure why this propagation was originally disabled, nor do I have enough tests out of tree to meaningfully exercise it.
A note: "we only want to traverse deps while dynamically linking" is potentially wrong when you have a setup that prefers the static link style but still allows dynamic linking (which is what we're in; we try to statically link first-party but Rust (rust-lang/rust#73632) and other things force dynamic linking).
This is more of a question for why it was off in the first place with a "yolo" button than a normal PR :)