fix(bundle_analysis): Prevent AttributeError when pull.database_pull is None - #2002
Open
sentry[bot] wants to merge 1 commit into
Open
fix(bundle_analysis): Prevent AttributeError when pull.database_pull is None#2002sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
Contributor
|
🤖 Harness AI Code Review in progress… · View results → |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses an
AttributeError: 'NoneType' object has no attribute 'get_comparedto_commit'occurring in bundle analysis notifications.Root Cause:
When
fetch_and_update_pull_request_informationencounters aTorngitClientError(e.g., PR not found on the git provider) and the pull request is also not present in the database, it returns anEnrichedPullobject wheredatabase_pullisNone. Thefetch_and_update_pull_request_information_from_commitfunction then passes thisEnrichedPullobject downstream. Later,ComparisonLoader.from_EnrichedPullattempts to accesspull.database_pull.get_comparedto_commit()without a null check, leading to theAttributeError.Solution:
Added a null check in
fetch_and_update_pull_request_information_from_committo explicitly returnNoneifenriched_pull.database_pullisNone. This ensures that functions callingfetch_and_update_pull_request_information_from_commit(likeload_enriched_pullin notification contexts) receiveNonewhen a valid database pull cannot be established, allowing them to handle the scenario gracefully (e.g., by raisingNotificationContextBuildErroror falling back to alternative comparison methods).Legal Boilerplate
Look, I get it. The entity doing business as "Codecov" is owned by Harness, Inc. In 2026 Harness acquired Codecov and as a result Harness is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Harness can use, modify, copy, and redistribute my contributions, under Harness's choice of terms.
Fixes WORKER-P81
This PR was automatically generated by Sentry. You can adjust this setting at any time.