Skip to content

feat: Private JWT CA support for passwordless - #158

Open
rmad17 wants to merge 1 commit into
mainfrom
feat/passwordless-support-ca
Open

feat: Private JWT CA support for passwordless#158
rmad17 wants to merge 1 commit into
mainfrom
feat/passwordless-support-ca

Conversation

@rmad17

@rmad17 rmad17 commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Changed

PasswordlessClient.start()

  • Removed the hardcoded "client_secret": client._client_secret field from the request body.
  • Added client._apply_client_authentication(body, f"https://{origin_domain}/", in_body=True) after the body is built, so credentials are attached by the SDK's shared helper instead of inline.

PasswordlessClient.verify()

  • Removed the same hardcoded "client_secret" field from the token-endpoint body.
  • Added client._apply_client_authentication(body, origin_issuer or f"https://{origin_domain}/", in_body=True), with the assertion audience taken from the discovery document's issuer and falling back to the
    resolved domain.

Testing
Tested via usual Passwordless flow as described in #153

@rmad17
rmad17 requested a review from a team as a code owner August 19, 2026 06:25

def __init__(self, code: str, message: str, cause=None, retry_after: Optional[int] = None):
super().__init__(code, message, cause, retry_after)
self.name = "PasswordlessStartError"

def __init__(self, code: str, message: str, cause=None, retry_after: Optional[int] = None):
super().__init__(code, message, cause, retry_after)
self.name = "PasswordlessVerifyError"
@rmad17
rmad17 changed the base branch from main to feat/passwordless-support August 19, 2026 06:27
Base automatically changed from feat/passwordless-support to main August 19, 2026 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants