feat(material/menu): add disabledInteractive input to MatMenuItem - #33693
Open
jermowery wants to merge 1 commit into
Open
feat(material/menu): add disabledInteractive input to MatMenuItem#33693jermowery wants to merge 1 commit into
jermowery wants to merge 1 commit into
Conversation
angular-robot
Bot
added
detected: feature
Contributor
Author
|
This was made with Jetski, internally at Google. I reviewed the code and it looks pretty similar to what I would have implemented myself |
crisbeto
reviewed
Aug 18, 2026
Member
|
Also worth noting that it seems like the menu keyboard navigation skips over disabled items right now. |
Contributor
Author
I wonder if the menu needs a bigger overhaul for a11y... |
jermowery
force-pushed
the
feat/mat-menu-item-disabled-interactive
branch
from
August 18, 2026 14:45
4ef5c22 to
de6578a
Compare
This adds the `disabledInteractive` input to `MatMenuItem`, bringing its behavior in line with `MatButton`. When `disabledInteractive` is true, the menu item takes on the visual styling of a disabled item and prevents default action on click, but allows for focus, hover states, and pointer events. This is useful for conveying why an item is disabled via a tooltip. Fixes angular#33692
jermowery
force-pushed
the
feat/mat-menu-item-disabled-interactive
branch
from
August 18, 2026 15:19
de6578a to
38d8ca5
Compare
Contributor
Author
|
cr/966590721 is the internal test of this, the TAP Train process is in progress |
Contributor
Author
|
TGP results are very positive Only two failing targets Both targets appear to be cases where aria-disabled is being set on the mat-menu-item but the menu item is being kept interactive, which I think could be solved by just using the very feature I am adding in this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the
disabledInteractiveinput toMatMenuItem, bringing its behavior in line withMatButton. WhendisabledInteractiveis true, the menu item takes on the visual styling of a disabled item and prevents default action on click, but allows for focus, hover states, and pointer events. This is useful for conveying why an item is disabled via a tooltip.Fixes #33692