style: satisfy the swiftlint strict gate in the operation reporting code - #2293
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This was referenced Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
swiftlint lint --strictfails onmainright now, on three violations that arrived with #2272:That gate is the
lintjob inbuild.yml, andreleaseneeds it, so the nextv*tag would have failed on this rather than on anything the tag introduced.It merged unseen because PR CI never runs SwiftLint.
macos-tests.ymlbuilds and tests; onlybuild.ymllints, and only on a tag. Worth closing separately, but this PR just clears the red.The fix
3600becomes3_600in both places.fileprivatemoves fromreportSaveFinishedonto the extension that holds it, which is whatextension_access_modifierasks for and whatCLAUDE.mdspecifies under Code Style. The extension has one member, so the effective access is unchanged.No behaviour change, so no CHANGELOG entry.
Verification
buildPASSlint TableProPASS, 0 violations (was 3 errors)testPASS, 111 of 111 across the suites touching the coordinators involved