chore(ci): remove the firestore flake probe workflow - #795
Open
tyler-reitz wants to merge 1 commit into
Open
Conversation
The probe was added in FirebaseExtended#780 as a temporary measurement tool for FirebaseExtended#776, which is now closed. It has no callers: nothing outside the file referenced it, and it was workflow_dispatch only, so removing it changes no scheduled or PR-triggered behaviour. FirebaseExtended#783's removal conditions were written when the @grpc/grpc-js override was still the candidate fix. That override was measured and did not work (5/60 vs 4/60, Fisher p = 1.0), so it never landed. The fix was FirebaseExtended#791's timeout ceilings instead, and the probe verified it: 0/60 flakes against an 11/60 baseline, with the desync rate statistically unchanged. Closes FirebaseExtended#783
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
.github/workflows/flake-probe.yamlwas added in #780 to measure the firestore flake in #776. #776 is now closed, so the probe has done its job.Verified while the file still exists, since afterwards neither claim can be checked without going back to this branch: it is
workflow_dispatchonly, and nothing outside the file references it. Removing it therefore changes no scheduled or PR-triggered behaviour, and it cannot orphan a required status check (mainrequirescla/google,Build,Test Node.js 22 (Ubuntu)andTest Node.js 24 (Ubuntu)).On #783's removal conditions
They were written when the
@grpc/grpc-jsoverride was still the candidate fix, so the checklist asks for the probe to be re-run "if the override lands". It never landed: the override was measured at 5/60 against a 4/60 baseline, Fisher p = 1.0.The conditions are met by a different route. The fix was #791's timeout ceilings, and the probe is what verified it: 0/60 flakes against an 11/60 baseline (p = 0.0006), with the desync rate statistically unchanged at 13/60 against 19/60. Five iterations show the rescue directly, passing at ~9.8s where the old 1000ms
waitForbudget gave up. Full result on #776.Closes #783